Quote Originally Posted by Greetingz View Post
The bar below says more then enough, it's not 2 hours.
It's a bug that has been reported a few times already, it only exists because of very sloppy coding and it's not excusable that it still exists... Even if you can see its more than 2 hours by using the bar as a reference, it should be fixed... There being another way to tell does not make it so that the bug doesn't exist, especially when it influences every timer including buff items of which some appear to have a 3 hour time limit instead of 3 days.

Let's make it even easier to fix, this is the function that causes the problem:
Code:
function time_show(seconds) {
  var txt = '';
  seconds = Math.round(seconds);
  var day = Math.floor(seconds / 86400);
  if (day) {
    txt += (day < 10) ? '0' + day : day;
    txt += ':';
    seconds -= day * 86400
  }
  var hour = Math.floor(seconds / 3600);
  if (hour) {
    txt += (hour < 10) ? '0' + hour : hour;
    txt += ':';
    seconds -= hour * 3600
  }
  var minute = Math.floor(seconds / 60);
  txt += (minute < 10) ? '0' + minute : minute;
  txt += ':';
  seconds -= minute * 60;
  txt += (seconds < 10) ? '0' + seconds : seconds;
  return monospaced(txt)
}
This is the fixed one that shows hours if there's 1 or more days in the timer:
Code:
function time_show(seconds) {
  var txt = '';
  seconds = Math.round(seconds);
  var day = Math.floor(seconds / 86400);
  if (day) {
    txt += (day < 10) ? '0' + day : day;
    txt += ':';
    seconds -= day * 86400
  }
  var hour = Math.floor(seconds / 3600);
  if (hour || day) {
    txt += (hour < 10) ? '0' + hour : hour;
    txt += ':';
    seconds -= hour * 3600
  }
  var minute = Math.floor(seconds / 60);
  txt += (minute < 10) ? '0' + minute : minute;
  txt += ':';
  seconds -= minute * 60;
  txt += (seconds < 10) ? '0' + seconds : seconds;
  return monospaced(txt)
}
The only thing that needed to change was adding "|| day" to the hour part... There is no excuse to not fix the bug part of it. This didn't even take 10 seconds to change... Always showing the hours/days or not is ultimately up to the devs, but this should be fixed like any bug.


Also Greetingz, why are you always so rude lately to people who point out problems? Just because you don't mind it or there is a way around it, it doesn't mean the problem isn't there... If someone doesn't like something, it's pretty much expected by now that you come and try to shoot them down... You are the wiki maintainer and the discord manager, as you proudly declare in your signature, but that also means you are part of the games representatives even if it's as a volunteer. You should pay more attention to how you come across, because it doesn't leave a good impression when someone in your position goes around acting like other people aren't allowed to have issues with things you don't have issues with and even insulting people.

The way you replied here gives the impression that you don't acknowledge the problem, despite part of it being a very obvious bug, and even blame the person who reported it for not using the bar to judge the remaining time. A better way to have worded it could be "The bar below can help you tell how much time there is left, it shows there is more than 2 hours remaining.", which would still get the point across but wouldn't seem like you are looking down on the person as much.