The max affection bonus remains the same whether you evolve your knight at 0% affection or at 100% affection.
It gets doubled on evolution, yes, but it gets double stat gains after evolution as well, which in the end makes no difference when the evolution occurs.